Skip to content

chore: update @actions/*#55

Draft
louisbennett wants to merge 3 commits intomainfrom
202603-actions
Draft

chore: update @actions/*#55
louisbennett wants to merge 3 commits intomainfrom
202603-actions

Conversation

@louisbennett
Copy link
Contributor

@louisbennett louisbennett commented Mar 11, 2026

Updating some of the guts of this action to keep up-to-date with now-vulnerable dependencies.

Changes include:

  • update @actions/core and @actions/github to current versions
  • update jest to support ESM-only libs (e.g.: @actions/core)
  • update packaging process from ncc to esbuild to support ESM-only libs
  • update from node20 to node24 as node20 is deprecated

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the build/bundling approach and GitHub Actions toolkit dependencies for the setup-hctl Node20 GitHub Action.

Changes:

  • Switches the packaging step from @vercel/ncc to esbuild for bundling src/index.ts into dist/index.js.
  • Upgrades @actions/core and @actions/github to newer major versions and updates the lockfile accordingly.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 3 comments.

File Description
package.json Replaces the bundling command with esbuild and bumps @actions/* dependencies.
package-lock.json Updates the resolved dependency tree to match the new versions and build tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

package.json Outdated
"format:check": "prettier --check **/*.ts",
"lint": "npx eslint",
"package": "ncc build src/index.ts",
"package": "esbuild src/index.ts --bundle --platform=node --target=node20 --outfile=dist/index.js",
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The esbuild packaging command relies on esbuild defaults for module format. Since this repo is a Node20 GitHub Action and the package is not marked as ESM (no type: module), it would be safer to make the output module format explicit (e.g., CJS) to avoid accidental format changes and runtime breakage if esbuild defaults/settings change.

Suggested change
"package": "esbuild src/index.ts --bundle --platform=node --target=node20 --outfile=dist/index.js",
"package": "esbuild src/index.ts --bundle --platform=node --target=node20 --format=cjs --outfile=dist/index.js",

Copilot uses AI. Check for mistakes.
@louisbennett louisbennett marked this pull request as draft March 11, 2026 10:58
auto-merge was automatically disabled March 11, 2026 10:58

Pull request was converted to draft

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants