Conversation
There was a problem hiding this comment.
Pull request overview
Updates the build/bundling approach and GitHub Actions toolkit dependencies for the setup-hctl Node20 GitHub Action.
Changes:
- Switches the packaging step from
@vercel/ncctoesbuildfor bundlingsrc/index.tsintodist/index.js. - Upgrades
@actions/coreand@actions/githubto newer major versions and updates the lockfile accordingly.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Replaces the bundling command with esbuild and bumps @actions/* dependencies. |
| package-lock.json | Updates the resolved dependency tree to match the new versions and build tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
package.json
Outdated
| "format:check": "prettier --check **/*.ts", | ||
| "lint": "npx eslint", | ||
| "package": "ncc build src/index.ts", | ||
| "package": "esbuild src/index.ts --bundle --platform=node --target=node20 --outfile=dist/index.js", |
There was a problem hiding this comment.
The esbuild packaging command relies on esbuild defaults for module format. Since this repo is a Node20 GitHub Action and the package is not marked as ESM (no type: module), it would be safer to make the output module format explicit (e.g., CJS) to avoid accidental format changes and runtime breakage if esbuild defaults/settings change.
| "package": "esbuild src/index.ts --bundle --platform=node --target=node20 --outfile=dist/index.js", | |
| "package": "esbuild src/index.ts --bundle --platform=node --target=node20 --format=cjs --outfile=dist/index.js", |
Pull request was converted to draft
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updating some of the guts of this action to keep up-to-date with now-vulnerable dependencies.
Changes include:
ncctoesbuildto support ESM-only libs