Skip to content

🔍 Add guidance on choosing max_length value and include visualization tool #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 28, 2025

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Jun 22, 2025

Screenshot 2025-07-26 at 4 40 19 PM Screenshot 2025-07-26 at 4 40 22 PM

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title 🔍 Add guidance on choosing max_length value and include visualizati… 🔍 Add guidance on choosing max_length value and include visualization tool Jul 26, 2025
Copy link
Collaborator

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment about mentioning padding free training which should be more efficient with longer seqs + no packinh.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice visualiser! LGTM with a nit about the viz labels

@qgallouedec qgallouedec merged commit 3d765b0 into main Jul 28, 2025
2 checks passed
@qgallouedec qgallouedec deleted the max-length-guide branch July 28, 2025 22:29
marcandrelarochelle pushed a commit to marcandrelarochelle/trl that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants