Stop inheriting tests (again) #42247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2, granitemoehybrid |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
tengomucho
approved these changes
Nov 17, 2025
|
|
||
| @require_torch | ||
| class GraniteMoeHybridModelTest(BambaModelTest, GenerationTesterMixin, unittest.TestCase): | ||
| class GraniteMoeHybridModelTest(ModelTesterMixin, GenerationTesterMixin, PipelineTesterMixin, unittest.TestCase): |
Contributor
There was a problem hiding this comment.
Perhaps add a comment explaining why it is better not to inherit from another test, so if someone is tempted to do the same, that someone will have a hint
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #42192 - after discussion, we decided not to use
deland instead to avoid importingTestCaseclasses.