-
Notifications
You must be signed in to change notification settings - Fork 31.2k
fix(ci): unexpected keyword argument streaming
#42102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, nice catch, thank you!
For me, I would probably use something like
- name: Update clone
working-directory: /transformers
env:
commit_sha: ${{ github.sha }}
run: |
git fetch origin "$commit_sha" && git checkout "$commit_sha"
It's not a technical reason, but it's what I did for all workflow files where we use our CI docker images. But since you maintain the benchmark workflows, it's up to you to make the call :-)
d84ce9a to
afeb173
Compare
I'd rather keep my workflow standard with the actions/checkout step! Will change if it is too confusing |
|
Ty all! |
I suspect some sort of error where we're not working with the correct up to date code of transformers in the benchmarks, which definitely is an issue.
EDIT: culprit seems to be:
and thinking of it indeed, it's not what we just checked out but transformers dir of the docler image