Show the normalizer failure in the triage outcome recap - #53
Merged
Conversation
When a dispatched group opens no PR, the recap showed only Serge's
terminal message. On the error path that names the last symptom, not the
cause: the 2026-07-29 longcat_flash group read "LLM returned unparseable
output" when what actually killed it was the normalizer failing on
check_docstrings against a checker the patch could not influence. A
reviewer had to open the Serge dashboard to learn that.
Consume the new `normalizer_error` field from Serge's /status: lift the
failing checker's name into the Reason cell ("normalizer: 1 failed:
docstrings") and render the output tail in a collapsible under the table,
so a reviewer can tell a patch the model got wrong from a normalizer
failure the patch never caused.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tarekziade
force-pushed
the
fix/triage-recap-normalizer
branch
from
July 30, 2026 07:17
7c5d142 to
92738bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In transformers#47631 the recap explained the
longcat_flashgroup as:That is the last symptom. The run was actually killed by the repo normalizer failing on
check_docstrings— a failure the patch could not have caused or fixed (the runner image's bakedtransformerspredated a model that had landed onmain51 minutes earlier). A reviewer reading the issue had no way to tell those two situations apart without opening the Serge dashboard.The
resnetrow had the opposite problem: its reason was the normalizer, but the cell ended at the colon (…before a clean patch was found:) because the recap keeps only the first line — the checker name was cut off.What
Consumes the new
normalizer_errorfield from Serge's/status(huggingface/serge#84):… — normalizer: 1 failed: docstringsFalls back to Serge's
Normalizer failed (exit N)preamble when there is no checker summary (amake stylecrash, a timeout), and is a no-op against a Serge build that does not send the field.Rendered against the real longcat_flash payload:
Test
tests/test_integration_failure_triage.py: the error-path shape above, the exit-line fallback, block placement after the table, tail preservation under the bound, and a fence longer than any backtick run in the captured output. 88 passed.Pre-existing failures in
test_export.py/test_resource_plugin.pyare a missingopentelemetryin the local venv, identical at HEAD.🤖 Generated with Claude Code