Skip to content

feat: ROCm flash-attn varlen, triton layer norm, and AMD Dockerfile - #860

Open
Abdennacer-Badaoui wants to merge 11 commits into
huggingface:mainfrom
Abdennacer-Badaoui:fa-varlen
Open

feat: ROCm flash-attn varlen, triton layer norm, and AMD Dockerfile#860
Abdennacer-Badaoui wants to merge 11 commits into
huggingface:mainfrom
Abdennacer-Badaoui:fa-varlen

Conversation

@Abdennacer-Badaoui

Copy link
Copy Markdown
Member

Adds flash attention varlen, triton-based layer norm/rms norm via kernels-community/triton-layer-norm, and a dedicated Dockerfile-amd with CI matrix entry for MI300/MI325 GPUs.

@Abdennacer-Badaoui
Abdennacer-Badaoui marked this pull request as draft April 9, 2026 10:05
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Abdennacer-Badaoui
Abdennacer-Badaoui marked this pull request as ready for review April 9, 2026 13:25
alvarobartt
alvarobartt previously approved these changes Jul 8, 2026

@alvarobartt alvarobartt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Abdennacer-Badaoui, thanks a lot, left some comments / thoughts, feel free to apply or discard where applicable 🤗

Comment thread backends/python/server/text_embeddings_server/models/flash_bert.py Outdated
Comment thread backends/python/server/text_embeddings_server/models/flash_mistral.py Outdated
Comment thread docs/source/en/amd_gpu.md
Comment thread docs/source/en/amd_gpu.md Outdated
Comment thread Dockerfile-amd Outdated
Comment thread Dockerfile-amd Outdated
Comment thread Dockerfile-amd Outdated
Comment thread .github/workflows/matrix.json Outdated
Comment thread .github/workflows/matrix.json Outdated
alvarobartt
alvarobartt previously approved these changes Jul 9, 2026
Comment thread backends/python/server/text_embeddings_server/utils/flash_attn.py
Comment thread backends/python/server/text_embeddings_server/utils/flash_attn.py Outdated
Comment thread Dockerfile-amd Outdated
Comment thread Dockerfile-amd Outdated
Comment thread Dockerfile-rocm
Comment thread .github/workflows/matrix.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants