-
Notifications
You must be signed in to change notification settings - Fork 2k
Implement FunctionTool #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
albertvillanova
wants to merge
10
commits into
huggingface:main
Choose a base branch
from
albertvillanova:refactor-tools-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement FunctionTool #1604
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e11f087
Implement FunctionTool
albertvillanova 9572787
Fix style
albertvillanova b1acd85
Test FunctionTool
albertvillanova d7fb586
Merge remote-tracking branch 'upstream/main' into refactor-tools-2
albertvillanova 0df28db
Merge remote-tracking branch 'upstream/main' into refactor-tools-2
albertvillanova 7568018
Merge remote-tracking branch 'upstream/main' into refactor-tools-2
albertvillanova 6fd88e1
Add FunctionTool to __all__
albertvillanova 7cd8e99
Implement function_tool
albertvillanova 145e711
Add function_tool to __all__
albertvillanova 2ebd4c6
Move __all__ to top of the module
albertvillanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this refactoring!
For the decorator, why not keep the simple name
@tool
?"function_"
is not needed since users already know that what they are using as source is a function, they just want to convert it to a tool, thus@tool
is enough IMOThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because of backward compatibility: we should first deprecate the old
tool
decorator and eventually replace it with the new one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you manage to maintain functionality (as judged by all the tests passing), switching the logic behind the decorator shouldn't break anything?