Skip to content

sgl-flash-attn3: switch to torch stable ABI - #1054

Open
adarshxs wants to merge 4 commits into
huggingface:mainfrom
adarshxs:sgl-stable-abi
Open

sgl-flash-attn3: switch to torch stable ABI#1054
adarshxs wants to merge 4 commits into
huggingface:mainfrom
adarshxs:sgl-stable-abi

Conversation

@adarshxs

@adarshxs adarshxs commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Ports sgl-flash-attn3 to the Torch stable ABI.

Motivation

Changes

Testing

Checklist

  • This PR is linked to an issue that was discussed and approved
  • I have tested these changes locally
  • New/changed functionality has test coverage
  • LLM disclosure:
    • I did not use an LLM to create this PR.
    • I used and LLM for assistance while creating this PR.
    • This PR was mostly or completely generated by an LLM.

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Jul 31, 2026
@danieldk

danieldk commented Aug 3, 2026

Copy link
Copy Markdown
Member

/kernel-bot build-and-stage sgl-flash-attn3

@github-actions

github-actions Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage sgl-flash-attn3
Mode: build and stage
Target branch: pr-1054
PR head SHA: fb414e7405b003e283a865d911fe9fa7bd95bda4
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul

sayakpaul commented Aug 6, 2026

Copy link
Copy Markdown
Member

@adarshxs could you look into the build failures?

@adarshxs adarshxs mentioned this pull request Aug 10, 2026
Open
adarshxs and others added 2 commits August 10, 2026 16:25
@adarshxs
Merge branch 'main' into sgl-stable-abi
45b8372
@adarshxs
sgl-flash-attn3: pin CUDA maxver to 13.0
7d5a87f 
ptxas 13.2 hits an internal compiler error (C7907) when building the
sm90 bf16 aggregators (flash_fwd_hdimall_bf16{,_softcap}_sm90.cu).
CUDA 12.8 and 13.0 build cleanly and the 13.0 build is backwards
compatible, so cap the matrix at 13.0.
@sayakpaul

sayakpaul commented Aug 10, 2026

Copy link
Copy Markdown
Member

/kernel-bot build-and-stage sgl-flash-attn3

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage sgl-flash-attn3
Mode: build and stage
Target branch: pr-1054
PR head SHA: 7d5a87fc73ff3df5cf6a155ca66482623b6a456d
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@adarshxs

adarshxs commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

/kernel-bot build-and-stage sgl-flash-attn3

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

I can only run /kernel-bot build-and-stage for users with write or admin repository permission.

@sayakpaul

sayakpaul commented Aug 11, 2026

Copy link
Copy Markdown
Member

/kernel-bot build-and-stage sgl-flash-attn3

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage sgl-flash-attn3
Mode: build and stage
Target branch: pr-1054
PR head SHA: 7d5a87fc73ff3df5cf6a155ca66482623b6a456d
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@sayakpaul

sayakpaul commented Aug 11, 2026

Copy link
Copy Markdown
Member

@adarshxs could we also do #1032?

@adarshxs

adarshxs commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@sayakpaul already done in this

@sayakpaul

sayakpaul commented Aug 12, 2026

Copy link
Copy Markdown
Member

/kernel-bot build-and-stage sgl-flash-attn3

@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage sgl-flash-attn3
Mode: build and stage
Target branch: pr-1054
PR head SHA: 6197185e86f45802082545c29a04d1bcff291c1e
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adarshxs @danieldk @sayakpaul