Skip to content

Fix variable reference for PR_REF in workflow #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coyotte508 merged 3 commits into from
Dec 12, 2025
Merged

Fix variable reference for PR_REF in workflow #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35802d9
Fix variable reference for PR_REF in workflow
glegendre01 Dec 11, 2025
d1cf9cf
Fix formatting in test.yml workflow
glegendre01 Dec 11, 2025
340dce9
format + fix lint job maybe
coyotte508 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ jobs:
then
echo "SINCE=$SHA^1" >> $GITHUB_OUTPUT
else
echo "SINCE=$(git merge-base origin/$PR_REF $SHA)" >> $GITHUB_OUTPUT
echo "SINCE=$(git merge-base $BASE_REF $SHA)" >> $GITHUB_OUTPUT
Copy link

@ydshieh ydshieh Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave this for you two. For security issue we intent to fix, this current version is good.

fi
env:
PR_REF: ${{ github.event.pull_request.head.ref }}
BASE_REF: origin/${{ github.event.pull_request.base.ref }}
Comment on lines +25 to +29
Copy link
Member

@coyotte508 coyotte508 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, maybe it'll fix the lint problem we've had (lint job succeeding before merging)

cc @Wauplin for viz

SHA: ${{ github.sha }}

- run: npm install -g corepack@latest && corepack enable
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,15 @@ jobs:
fetch-depth: 0
- name: "Extracting the merge base into 'SINCE'"
id: since
env:
PR_REF: ${{ github.event.pull_request.head.ref }}
BASE_REF: origin/${{ github.event.pull_request.base.ref }}
run: |
if [ -z "${{ github.event.pull_request.head.ref }}" ]
if [ -z $PR_REF ]
then
echo "SINCE=${{ github.sha }}^1" >> $GITHUB_OUTPUT
else
echo "SINCE=$(git merge-base origin/${{ github.event.pull_request.base.ref }} ${{ github.sha }})" >> $GITHUB_OUTPUT
echo "SINCE=$(git merge-base $BASE_REF ${{ github.sha }})" >> $GITHUB_OUTPUT
fi
- run: npm install -g corepack@latest && corepack enable
Expand Down Expand Up @@ -53,8 +56,10 @@ jobs:
fetch-depth: 0
- name: "Extracting the merge base into 'SINCE'"
id: since
env:
PR_REF: ${{ github.event.pull_request.head.ref }}
run: |
if [ -z "${{ github.event.pull_request.head.ref }}" ]
if [ -z $PR_REF ]
then
echo "SINCE=${{ github.sha }}^1" >> $GITHUB_OUTPUT
else
Expand Down