Add SongBloom as a library #1571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cypress-Yang
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
Wauplin
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Looks good to me! Just a comment on the download counts but otherwise ready to merge.
(and I saw https://huggingface.co/models?other=songbloom is already populated 👍 )
| repoName: "SongBloom", | ||
| repoUrl: "https://github.com/Cypress-Yang/SongBloom", | ||
| filter: false, | ||
| countDownloads: `path_extension:"ckpt" OR path_extension:"pt"`, |
There was a problem hiding this comment.
Suggested change
| countDownloads: `path_extension:"ckpt" OR path_extension:"pt"`, | |
| countDownloads: `path:"songbloom_full_150s.pt", |
Let's count downloads on a single file to avoid duplicate counting (otherwise, downloading the repo would count a 2 downloads).
There was a problem hiding this comment.
We plan to add other versions of the model into the repo, so maybe it should be path_extension:"pt"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.