nits on skills post #3221
Merged
nits on skills post #3221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to these minor nits, I found some inconsistency with the model training size. It says [here](https://github.com/huggingface/blog/blob/92fc1c627876e748f6e29cdfa3935815d708e342/hf-skills-training.md?plain=1#L36) that we support up to 70B params, then we say it's [7B here](https://github.com/huggingface/blog/blob/92fc1c627876e748f6e29cdfa3935815d708e342/hf-skills-training.md?plain=1#L252), and the [table we show in the post](https://github.com/huggingface/blog/blob/main/hf-skills-training.md?plain=1#L246-L252) does not match the one [from the skill itself](https://github.com/huggingface/skills/blob/main/hf-llm-trainer/skills/model-trainer/SKILL.md#hardware-selection).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to these minor nits, I found some inconsistency with the supported model sizes. It says here that we support up to 70B params, then we say it's 7B here, and the table we show in the post does not match the one from the skill itself.