Avoid using nvidia-smi on a CPU-only Colab instance #3872
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On a CPU-only Colab notebook, nvidia-smi is not available. Running notebook_launcher was running into an error because of that, assuming that we were using Colab with a GPU.
The fix check first if torch has detected a GPU, if so it goes on with the usual check with nvidia-smi, if there is no GPU, the code does not run nvidia-smi as it is not available.
Not sure how to add tests here as it is in a specific env, open to suggestions :)
Fixes #3871
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc ?