Skip to content

Bugfix: block dragging first and last slides for infinite config. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mastersanto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix: block dragging first and last slides for infinite config. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,18 +237,37 @@ export default class Carousel {
* @return {void}
*/
_drag(e) {
var touches;
var touches,
currentSlide,
slidesLength,
isSwippingRightFirstSlide,
isSwippingLeftLastSlide;

if (!this.dragging) {
return;
}

currentSlide = this.current + 1;
slidesLength = this.numSlides;
e = e.originalEvent || e;
touches = e.touches !== undefined ? e.touches : false;
this.deltaX = (touches ? touches[0].pageX : e.clientX) - this.startClientX;
this.deltaY = (touches ? touches[0].pageY : e.clientY) - this.startClientY;

// drag slide along with cursor
// Block slide dragging for first and last slides
// preventing to show an empty space before first and after last slides.
if (!this.infinite) {
// FIRST slide and swipping to RIGHT
isSwippingRightFirstSlide = currentSlide === 1 && this.deltaX > 0;
// LAST slide and swipping to LEFT
isSwippingLeftLastSlide = currentSlide === slidesLength && this.deltaX < 0;

if (isSwippingRightFirstSlide || isSwippingLeftLastSlide) {
return false;
}
}

// drag slide along with cursor
this._slide( -(this.current * this.width - this.deltaX ) );

// determine if we should do slide, or cancel and let the event pass through to the page
Expand Down