re-raise exceptions in the _handle_json_response #321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes runtime monkey-patching of MCP transport internals; behavior shifts from swallowed errors to raised exceptions, which may affect retry/error flows in production if upstream expectations differ.
Overview
Fixes a hang in MCP streamable HTTP requests by patching
StreamableHTTPTransport._handle_json_responseto log and re-raise exceptions fromresponse.aread()and JSON parsing instead of sending raw exceptions into the read stream.Registers this new patch in
apply_all_patches()so it is applied alongside the existing streamable HTTP error-handling patch.Written by Cursor Bugbot for commit 033ecca. This will update automatically on new commits. Configure here.