feat(gm): support GM #164
Merged
feat(gm): support GM #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zippo-Wang
force-pushed
the
feat_gm
branch
7 times, most recently
from
21aed4b to
3bdd2ee
Compare
Collaborator
chengxiangdong
left a comment
chengxiangdong
left a comment
There was a problem hiding this comment.
It is recommended to put gm_round_tripper.go, gm_round_tripper_test.go, logroundtripper.go, logroundtripper_test.go and transport.go in pkg/common/transport.
pkg/config/cloud.go
Outdated
Comment on lines
158
to
166
| VerifyPeerCertificate: func(rawCerts [][]byte, verifiedChains [][]*x509.Certificate) error { | ||
| for _, v := range rawCerts { | ||
| _, err = x509.ParseCertificate(v) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| }, |
Collaborator
There was a problem hiding this comment.
VerifyPeerCertificate not necessary and should be removed
pkg/config/cloud.go
Outdated
| if c.Global.GMSupport { | ||
| gmCfg := &gmtls.Config{ | ||
| GMSupport: &gmtls.GMSupport{WorkMode: gmtls.ModeAutoSwitch}, | ||
| InsecureSkipVerify: true, |
Collaborator
There was a problem hiding this comment.
Suggested change
| InsecureSkipVerify: true, | |
| InsecureSkipVerify: c.Global.Insecure, |
pkg/config/cloud.go
Outdated
| if c.Global.GMSupport { | ||
| gmCfg := &gmtls.Config{ | ||
| GMSupport: &gmtls.GMSupport{WorkMode: gmtls.ModeAutoSwitch}, | ||
| InsecureSkipVerify: true, |
Collaborator
There was a problem hiding this comment.
Suggested change
| InsecureSkipVerify: true, | |
| InsecureSkipVerify: c.Global.Insecure, |
Zippo-Wang
force-pushed
the
feat_gm
branch
4 times, most recently
from
7995678 to
c7837f3
Compare
Collaborator
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: