Fix case-sensitive detection of streaming event-stream responses - #1955
Closed
harsh-thakkar7 wants to merge 1 commit into
Closed
harsh-thakkar7 wants to merge 1 commit into
harsh-thakkar7 wants to merge 1 commit into
Conversation
Media types are case-insensitive per RFC 2045 section 5.1, but the auto-streaming check for Server-Sent Events compared the parsed Content-Type header literally, so a server responding with e.g. 'Text/Event-Stream' silently fell back to buffered output.
Author
|
Closing this — I don't think this change is mature enough to land right now. Thanks for the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Servers may send the
Content-Typeheader for Server-Sent Events with any casing (RFC 2045 §5.1: "media types are case-insensitive"). HTTPie's auto-streaming detection compared the parsed media type literally:so a response with e.g.
Content-Type: Text/Event-Streamsilently disabled the documented SSE auto-streaming (falling back to buffered output withchunk_size=102400instead of line-by-linechunk_size=1).Fix
Compare the media type case-insensitively:
Tests
Added a parametrized case to
test_auto_streaming(aText/Event-Streamresponse is now streamed line-by-line, yielding 3 writes oftestinstead of 1 buffered write). The new case fails before this change (1 failed) and passes after (4 passed full suite for the test module).pytest -q tests/test_stream.py # 17 passed