feat(SLAC-5): Make a alias for featurerequest command, "fr"

templates/help/helpText.txt

@@ -26,7 +26,7 @@
 > `flushvote` - Vote to clear the entire queue. Needs *{{flushVoteLimit}}* votes within *{{voteTimeLimitMinutes}}* min. 🗑️
 
 *📝 Feedback:*
-> `featurerequest <feature description>` - Create a GitHub issue for a feature request. ✨
+> `featurerequest` (alias: `fr`) `<feature description>` - Create a GitHub issue for a feature request. ✨
 
 _Tip: You can use Spotify URIs (spotify:track:...) OR paste Spotify links (https://open.spotify.com/...) with add, append, addalbum, and addplaylist commands!_
 

test/aicode-agent.test.mjs

@@ -22,6 +22,26 @@ describe('Feature Request Integration', function() {
       // Check handler function exists
       expect(content).to.include('async function _featurerequest(input, channel, userName)');
     });
+
+    it('should have "fr" alias registered pointing to the same handler as featurerequest', function() {
+      const indexPath = path.join(process.cwd(), 'index.js');
+      const content = fs.readFileSync(indexPath, 'utf8');
+
+      // Check that 'fr' alias is registered with the same handler
+      expect(content).to.include("['fr', { fn: _featurerequest");
+    });
+
+    it('should register "fr" and "featurerequest" with the same handler function', function() {
+      const indexPath = path.join(process.cwd(), 'index.js');
+      const content = fs.readFileSync(indexPath, 'utf8');
+
+      // Both should reference _featurerequest as their handler
+      const featureRequestMatch = content.includes("['featurerequest', { fn: _featurerequest");
+      const frMatch = content.includes("['fr', { fn: _featurerequest");
+
+      expect(featureRequestMatch).to.be.true;
+      expect(frMatch).to.be.true;
+    });
   });
 
   describe('GitHub Issue Creation', function() {
@@ -56,5 +76,14 @@ describe('Feature Request Integration', function() {
 
       expect(content).to.include('featurerequest');
     });
+
+    it('should document the "fr" alias in the standard help text', function() {
+      const helpPath = path.join(process.cwd(), 'templates', 'help', 'helpText.txt');
+      const content = fs.readFileSync(helpPath, 'utf8');
+
+      // The alias notation must appear (e.g. "alias: `fr`")
+      expect(content).to.include('featurerequest');
+      expect(content).to.match(/featurerequest.*alias.*fr/i);
+    });
   });
 });

test/slac-5-fr-alias.test.mjs

@@ -0,0 +1,184 @@
+/**
+ * Tests for SLAC-5 — Add "fr" Alias for `featurerequest` Command
+ *
+ * Verifies that:
+ *  - "fr" is registered as an alias pointing to the same handler as "featurerequest"
+ *  - The existing "featurerequest" command is unchanged
+ *  - Help text documents the "fr" alias
+ *  - No duplicated handler logic exists for "fr"
+ */
+
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import fs from 'fs';
+import path from 'path';
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+function readFile(relativePath) {
+  return fs.readFileSync(path.join(process.cwd(), relativePath), 'utf8');
+}
+
+// ---------------------------------------------------------------------------
+// Suite
+// ---------------------------------------------------------------------------
+
+describe('SLAC-5 — "fr" alias for featurerequest', function () {
+
+  // -------------------------------------------------------------------------
+  // Command Registration
+  // -------------------------------------------------------------------------
+
+  describe('Command Registration (index.js)', function () {
+
+    it('should still have the original "featurerequest" command registered', function () {
+      const content = readFile('index.js');
+      expect(content).to.include("['featurerequest', { fn: _featurerequest");
+    });
+
+    it('should have the "fr" alias registered', function () {
+      const content = readFile('index.js');
+      expect(content).to.include("['fr', { fn: _featurerequest");
+    });
+
+    it('should register "fr" with the same handler function as "featurerequest"', function () {
+      const content = readFile('index.js');
+
+      // Both entries must reference _featurerequest — no separate handler
+      const featureRequestRegistered = content.includes("['featurerequest', { fn: _featurerequest");
+      const frRegistered = content.includes("['fr', { fn: _featurerequest");
+
+      expect(featureRequestRegistered, '"featurerequest" registration with _featurerequest handler').to.be.true;
+      expect(frRegistered, '"fr" registration with _featurerequest handler').to.be.true;
+    });
+
+    it('should NOT define a separate handler function for "fr"', function () {
+      const content = readFile('index.js');
+
+      // There must be no dedicated _fr function — the alias reuses _featurerequest
+      expect(content).to.not.include('function _fr(');
+      expect(content).to.not.include('async function _fr(');
+    });
+
+    it('should have exactly one definition of the _featurerequest handler function', function () {
+      const content = readFile('index.js');
+
+      // Count occurrences of the function declaration
+      const matches = content.match(/async function _featurerequest\s*\(/g) || [];
+      expect(matches).to.have.lengthOf(1);
+    });
+
+    it('should have the _featurerequest handler accept (input, channel, userName) parameters', function () {
+      const content = readFile('index.js');
+      expect(content).to.include('async function _featurerequest(input, channel, userName)');
+    });
+  });
+
+  // -------------------------------------------------------------------------
+  // Handler Behaviour — source-level checks
+  // -------------------------------------------------------------------------
+
+  describe('Handler Behaviour', function () {
+
+    it('should use the GitHub Issues API endpoint in the handler', function () {
+      const content = readFile('index.js');
+      expect(content).to.include('api.github.com/repos/htilly/SlackONOS/issues');
+    });
+
+    it('should apply the "enhancement" label when creating a GitHub issue', function () {
+      const content = readFile('index.js');
+      expect(content).to.include("labels: ['enhancement']");
+    });
+
+    it('should include requester information in the issue body', function () {
+      const content = readFile('index.js');
+      expect(content).to.include('Requested by');
+    });
+  });
+
+  // -------------------------------------------------------------------------
+  // Help Text — user-facing documentation
+  // -------------------------------------------------------------------------
+
+  describe('Help Text Documentation', function () {
+
+    it('should document the "fr" alias in the standard help text', function () {
+      const content = readFile('templates/help/helpText.txt');
+      // The spec requires something like: featurerequest (alias: fr)
+      expect(content).to.include('featurerequest');
+      expect(content).to.include('fr');
+    });
+
+    it('should show "fr" as an alias for "featurerequest" in the standard help text', function () {
+      const content = readFile('templates/help/helpText.txt');
+      // Verify the alias notation is present (e.g. "alias: `fr`" or "(alias: fr)")
+      expect(content).to.match(/featurerequest.*alias.*fr/i);
+    });
+
+    it('should still document "featurerequest" in the admin help text', function () {
+      const content = readFile('templates/help/helpTextAdmin.txt');
+      expect(content).to.include('featurerequest');
+    });
+
+    it('should include the feature request entry in the Feedback section of standard help', function () {
+      const content = readFile('templates/help/helpText.txt');
+      // The Feedback section header must be present
+      expect(content).to.include('Feedback');
+      // And the featurerequest command must appear after it
+      const feedbackIndex = content.indexOf('Feedback');
+      const frIndex = content.indexOf('featurerequest', feedbackIndex);
+      expect(frIndex).to.be.greaterThan(feedbackIndex);
+    });
+  });
+
+  // -------------------------------------------------------------------------
+  // Configuration
+  // -------------------------------------------------------------------------
+
+  describe('Configuration', function () {
+
+    it('should have githubToken in the example config', function () {
+      const content = readFile('config/config.json.example');
+      expect(content).to.include('"githubToken"');
+    });
+  });
+
+  // -------------------------------------------------------------------------
+  // Alias parity — both keys must share identical registration shape
+  // -------------------------------------------------------------------------
+
+  describe('Alias Parity', function () {
+
+    it('"fr" and "featurerequest" registrations should reference the same handler name', function () {
+      const content = readFile('index.js');
+
+      // Extract the handler name used for each registration
+      const featureRequestMatch = content.match(/\['featurerequest',\s*\{\s*fn:\s*(\w+)/);
+      const frMatch = content.match(/\['fr',\s*\{\s*fn:\s*(\w+)/);
+
+      expect(featureRequestMatch, '"featurerequest" registration found').to.not.be.null;
+      expect(frMatch, '"fr" registration found').to.not.be.null;
+
+      const featureRequestHandler = featureRequestMatch[1];
+      const frHandler = frMatch[1];
+
+      expect(frHandler).to.equal(featureRequestHandler,
+        `"fr" handler (${frHandler}) must equal "featurerequest" handler (${featureRequestHandler})`);
+    });
+
+    it('"fr" should not trigger an unknown-command response', function () {
+      const content = readFile('index.js');
+
+      // The command map must contain 'fr' so the router never falls through
+      // to an unknown-command branch for this input
+      expect(content).to.include("'fr'");
+
+      // Confirm the unknown-command guard (if present) would not match 'fr'
+      // by ensuring 'fr' is a registered key — already verified above
+      const frRegistered = content.includes("['fr', { fn: _featurerequest");
+      expect(frRegistered).to.be.true;
+    });
+  });
+});