added logging to ddp messages #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hthiery
reviewed
Mar 8, 2018
| return | ||
|
|
||
| try: | ||
| if broadcast: |
Owner
There was a problem hiding this comment.
this should be removed form the try, except block ... maybe in another
Contributor
Author
There was a problem hiding this comment.
what part are you referring to here?
pyps4/ddp.py
Outdated
| sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) | ||
| except OSError as error: | ||
| _LOGGER.error('failed to create socket, %s', error) | ||
| return |
Owner
There was a problem hiding this comment.
I'm not sure if it is a good idea to return siliently. The errors would not be catched anymore.
Contributor
Author
There was a problem hiding this comment.
continuing just seems to break more, and the error is already reported, so I don't know what a better alternative would be.
basicly what you are trying is not working and you are informed why, in my opinion that seems better than breaking with an unhandled exception
added 8 commits
March 10, 2018 10:47
* 'master' of https://github.com/hthiery/python-ps4: readme: fix readme: update Add remote key feature add python 3.6 to travis build
…https://github.com/hthiery/python-ps4 * 'master' of github.com:hmn/python-ps4: * 'master' of https://github.com/hthiery/python-ps4: added docker testing/dev env fixed install dependency as pycryptodomex is only needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.