ENH: GPU idle_time and assorted GPU fixes#148
Merged
lithomas1 merged 3 commits intohpcgroup:developfrom May 2, 2025
Merged
Conversation
Collaborator
lithomas1
commented
May 2, 2025
- Account for idle time on GPU (calculated by taking total time and subtracting time in events)
- Add parent/child relationships for annotations (restores hierarchical nature of NVTX ranges)
- Refactor exclusive metrics calculation to account for overlap between parent/child event (since child event can be on a different device and be launched after parent event finishes)
There was a problem hiding this comment.
Pull Request Overview
This PR enhances GPU trace analysis by accounting for GPU idle time and fixes issues related to GPU event annotations and exclusive metric calculations.
- Refactors the caller/callee matching logic using groupby and a helper function.
- Updates exclusive metric calculations to correctly handle overlapping GPU event timings.
- Revises GPU idle time computation using groupby to streamline the calculation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pipit/trace.py | Refactored _match_caller_callee logic, updated exclusive metric calculation and idle time computation for improved handling of GPU overlaps and asynchronous execution. |
| pipit/readers/nsight_sqlite_reader.py | Updated DataFrame conversion and sorting, and refined parallelism level assignments based on trace types. |
Collaborator
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.