Conversation
pipit/trace.py
Outdated
| matching_events = list(self.events["_matching_event"]) | ||
| matching_times = list(self.events["_matching_timestamp"]) | ||
|
|
||
| mpi_events = self.events[ |
There was a problem hiding this comment.
Should rename to comm_events or some equivalent
pipit/trace.py
Outdated
| matching_times = list(self.events["_matching_timestamp"]) | ||
|
|
||
| mpi_events = self.events[ | ||
| self.events["Name"].isin(["MpiSend", "MpiRecv", "MpiIsend", "MpiIrecv"]) |
There was a problem hiding this comment.
Update to check if the event name is in send_events_names + receive_events_names
pipit/trace.py
Outdated
| self.events["Name"].isin(["MpiSend", "MpiRecv", "MpiIsend", "MpiIrecv"]) | ||
| ] | ||
|
|
||
| queue = [[] for _ in range(len(self.events["Process"].unique()))] |
There was a problem hiding this comment.
Update queue to be a dict per process, and index the dict per receiver process with sender processes. Also comments should be added to explain this.
pipit/trace.py
Outdated
| processes = list(mpi_events["Process"]) | ||
|
|
||
| # Iterate through all events | ||
| for i in range(len(mpi_events)): |
There was a problem hiding this comment.
Change to iterate over send events and receive events separately, so that if a process with a receive event is iterated over, we can confirm that the send event has already been seen and added to the queue.
pipit/trace.py
Outdated
| if curr_name == "MpiSend" or curr_name == "MpiIsend": | ||
| # Add current dataframe index, timestmap, and process to stack | ||
| if "receiver" in curr_attrs: | ||
| queue[curr_attrs["receiver"]].append( |
There was a problem hiding this comment.
Update for new dict queue implementation.
pipit/trace.py
Outdated
|
|
||
| # we want to iterate through the queue in order | ||
| # until we find the corresponding "send" event | ||
| while send_process != curr_attrs["sender"] and i < len( |
There was a problem hiding this comment.
Update for new dict queue implementation.
movsesyanae
added
priority: urgent
status: ready for review
and removed
status: revisions requested
labels
movsesyanae
force-pushed
the
match_messages
branch
from
eac3cae to
2ee3f03
Compare
|
I'm getting a key error when running on the Kripke 32-process trace. |
4 participants
No description provided.