Skip to content

[feat] Support Zero Bubble StreamRL-like RL Training #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: grpo-latest
Choose a base branch
from
Open

[feat] Support Zero Bubble StreamRL-like RL Training #6356

wants to merge 6 commits into from

Conversation

YeAnbang
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YeAnbang YeAnbang force-pushed the grpo-zero-bubble branch from 150ca20 to 509274c Compare July 9, 2025 03:33
@YeAnbang YeAnbang marked this pull request as ready for review July 9, 2025 05:04
@YeAnbang YeAnbang requested a review from a team as a code owner July 9, 2025 05:04
@YeAnbang YeAnbang requested a review from TongLi3701 July 11, 2025 01:35
TongLi3701
TongLi3701 reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang, some comments.

Please also fully test each plugin and make sure it will not influence others.

applications/ColossalChat/coati/distributed/zero_bubble/distributor.py
Comment on lines +118 to +119
def get_weight_version(self):
return min(self.weight_version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the weight version should be consistent, which means we need to make sure all chunks have the same version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you defined the length of the list is equal to pp size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TongLi3701 TongLi3701 TongLi3701 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YeAnbang @TongLi3701