Fixed: Added checks to prevent multiple API calls on different actions (#593)

[R-Sourabh]

Related Issues

#593

Short Description and Why It's Useful

Handled various multiple API call cases:

• Load More option in all segments and tabs.
• Proceed button on the Close Purchase Order Items alert.
• Order label on the Purchase Orders page in both segments.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

• I read and followed contribution rules

[gemini-code-assist]

Summary of Changes

Hello @R-Sourabh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where rapid user interactions could lead to multiple, redundant API calls, potentially causing unexpected behavior or performance degradation. By introducing state flags and conditional checks before initiating API requests, the changes ensure that critical actions like closing purchase order items, fetching order details, and loading more data are executed only once per user interaction, significantly enhancing the application's stability and user experience.

Highlights

• Prevented Duplicate API Calls on 'Proceed' Action: Implemented an isUpdating flag in ClosePurchaseOrderModal.vue to ensure that the updatePOItemStatus API call is not triggered multiple times when the 'Proceed' button is rapidly clicked on the 'Close Purchase Order Items' alert.
• Prevented Duplicate API Calls on Order Label Click: Added an isLoading flag in PurchaseOrderItem.vue to prevent multiple getOrderDetail API calls when an order label is clicked repeatedly, ensuring only one detail fetch occurs at a time.
• Prevented Duplicate API Calls for 'Load More' Actions: Introduced checks (e.g., fetchingOrders, fetchingReturns, fetchingShipments) across PurchaseOrders.vue, Returns.vue, Shipments.vue, and TransferOrders.vue to prevent multiple API calls when the 'Load More' functionality is activated, improving data fetching stability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds checks to prevent multiple API calls, which is a good improvement for user experience. However, the implementation in ClosePurchaseOrderModal.vue and PurchaseOrderItem.vue could lead to UI elements becoming unresponsive if an API call fails, as the loading state is not reset in case of an error. I've provided suggestions to use try...finally blocks to make the code more robust. Additionally, I've pointed out an async/await anti-pattern in PurchaseOrderItem.vue and suggested a cleaner approach.

[gemini-code-assist]

The current implementation does not handle potential errors within the async handler. If this.updatePOItemStatus() or this.router.push() throws an error, isUpdating will not be reset to false. This could leave the "Proceed" button in a permanently disabled state for the user. It's better to use a try...finally block to ensure isUpdating is always reset, regardless of whether the operation succeeds or fails.

            isUpdating = true;
            try {
              await this.updatePOItemStatus();
              modalController.dismiss();
              this.router.push('/purchase-orders');
            } finally {
              isUpdating = false;
            }