Skip to content

Fix flaky test cases for user role and level update in users list #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix flaky test cases for user role and level update in users list #7042

wants to merge 3 commits into from

Conversation

suzit-10
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Describe this PR

This PR addresses the flakiness in the UsersList tests related to updating mapper level and role.
The root cause was inconsistent rendering of the popup triggered by the table rows due to asynchronous TanStack Table rendering.

Changes made:

  • Introduced a flushPromises helper to flush React/TanStack updates after user interactions.
  • Ensured test setup waits for loading animation to disappear and rows/triggers to be fully rendered.
  • Replaced waitFor(getBy...) with findByTestId for stable async querying.
  • Used queryByTestId instead of stale references when validating popup unmount.
  • Added explicit timeout (10s) only for popup-related queries instead of globally extending Jest timeout.

@suzit-10
add testid identifier to popup trigger and popup content
f6ad5fa
@suzit-10
Remove unused variable function getAllByRole
14e1dfb
@suzit-10
Stabilize UsersList popup tests by adding flushPromises and proper wa…
dedccb7 
…itFor usage

Added flushPromises helper to ensure TanStack/React state updates complete before assertions

Replaced `waitFor` with `findByTestId` for better async handling
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suzit-10