Skip to content

Add additional err handling to SOAP template#50

Merged
c4milo merged 1 commit intohooklift:masterfrom
appropriate:additional-err-handling
Dec 17, 2015
Merged

Add additional err handling to SOAP template#50
c4milo merged 1 commit intohooklift:masterfrom
appropriate:additional-err-handling

Conversation

@md5
Copy link
Contributor

@md5 md5 commented Dec 17, 2015

These changes were proposed for the generated output file over at appropriate/go-virtualboxclient#1 and I thought they seemed reasonable.

Please take a look! 👍

c4milo added a commit that referenced this pull request Dec 17, 2015
Add additional err handling to SOAP template
@c4milo c4milo merged commit 18bb927 into hooklift:master Dec 17, 2015
@md5 md5 deleted the additional-err-handling branch December 17, 2015 07:07
@md5
Copy link
Contributor Author

md5 commented Dec 17, 2015

Thanks @c4milo!

@c4milo
Copy link
Member

c4milo commented Dec 17, 2015

No, thank you!
On Thu, Dec 17, 2015 at 2:07 AM Mike Dillon notifications@github.com
wrote:

Thanks @c4milo https://github.com/c4milo!


Reply to this email directly or view it on GitHub
#50 (comment).

@md5
Copy link
Contributor Author

md5 commented Dec 17, 2015

To give credit where credit is due, @clintonskitson was the source of these changes. 👍

@md5
Copy link
Contributor Author

md5 commented Dec 22, 2015

@c4milo Are you planning on cutting a new release that includes changes since v0.2.0 any time soon?

@c4milo
Copy link
Member

c4milo commented Dec 22, 2015

@md5 a new release will be up shortly.

@c4milo
Copy link
Member

c4milo commented Dec 22, 2015

@md5 landed in v0.2.1

@md5
Copy link
Contributor Author

md5 commented Dec 22, 2015

Thanks @c4milo. You rock! 🤘

@md5
Copy link
Contributor Author

md5 commented Dec 22, 2015

I ended up making a Homebrew tap for gowsdl to help out us OS X users: https://github.com/appropriate/homebrew-gowsdl

It can be used like so:

$ brew tap appropriate/gowsdl
$ brew install gowsdl

If there's any interest, it would probably be pretty uncontroversial to add it to Homebrew itself. I'd also be happy to share ownership of the repo and/or transfer it under hooklift.

@c4milo
Copy link
Member

c4milo commented Dec 22, 2015

I don't have strong feelings against it.

@md5
Copy link
Contributor Author

md5 commented Dec 23, 2015

I've opened a PR to add gowsdl to Homebrew proper: Homebrew/legacy-homebrew#47282

@c4milo
Copy link
Member

c4milo commented Dec 23, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants