Skip to content

feat: expose serialization package #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: expose serialization package #93

wants to merge 1 commit into from

Conversation

@cyberhck
Copy link
Collaborator

@cyberhck cyberhck commented Feb 12, 2024 •
edited by jai
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to
    the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • we need to be able to use serialization package from kp externally since there's no type safe consumer in KP yet. Hence we're extracting this package out.

This change is Reviewable

@cyberhck cyberhck requested a review from a team as a code owner February 12, 2024 08:24
@cyberhck cyberhck changed the title feat: add an encoding package feat: expose serialization package Feb 12, 2024
@cyberhck cyberhck force-pushed the nishchal/expose-encoding-package branch from d3b788c to 78ea4f3 Compare February 12, 2024 08:38
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 12, 2024
@cyberhck cyberhck force-pushed the nishchal/expose-encoding-package branch from 78ea4f3 to ee5ac7e Compare February 12, 2024 08:43
@pull-request-size pull-request-size bot added size/S and removed size/M labels Feb 12, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onkarbanerjee onkarbanerjee onkarbanerjee approved these changes

+2 more reviewers

@maetolay maetolay maetolay approved these changes

@hasan-honest hasan-honest hasan-honest approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyberhck @maetolay @onkarbanerjee @hasan-honest