Skip to content

chore: flaky tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: flaky tests #6

wants to merge 5 commits into from

Conversation

@bludot
Copy link
Contributor

@bludot bludot commented Apr 3, 2023 •
edited by jai
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to
    the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • fix flaky tests

does not need experiment

This change is Reviewable

@bludot bludot requested a review from a team as a code owner April 3, 2023 03:59
@bludot bludot requested a review from jeremyrajan April 3, 2023 03:59
@bludot bludot force-pushed the james/spe-2164-fix-flaky-tests branch from 54c48ba to 590f870 Compare April 3, 2023 04:00
@github-advanced-security
Copy link

github-advanced-security bot commented Apr 3, 2023

You have successfully added a new Trivy configuration .github/workflows/trivy_scan.yaml:trivy-scan. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@pull-request-size pull-request-size bot added size/XS and removed size/L labels Apr 3, 2023
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Apr 3, 2023
@bludot bludot changed the title fix: flaky tests chore: flaky tests Apr 3, 2023
cyberhck
cyberhck previously approved these changes Apr 3, 2023
View reviewed changes
poom
poom previously approved these changes Apr 3, 2023
View reviewed changes
@bludot bludot dismissed stale reviews from poom and cyberhck via c446bb5 March 21, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremyrajan jeremyrajan Awaiting requested review from jeremyrajan jeremyrajan is a code owner automatically assigned from honestbank/backend-engineers

2 more reviewers

@poom poom poom left review comments

@cyberhck cyberhck cyberhck left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bludot @poom @cyberhck