feat(storage/rds): Fix Checkov findings [SPE-491, SPE-488, SPE-489, SPE-91]

[jai]

Info Required for All Commits

Description:

• refactor(storage/rds): Enable enhanced logging
• refactor(storage/rds): Enable multi-AZ on prod
• refactor(storage/rds): Enable deletion protection
• refactor(storage/rds): Enable enhanced monitoring

---

This change is 

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/honestbank/argoflow-aws-infrastructure/runs/run-Gk6nh5s55XbZEwzn

Waiting for the plan to start...

Terraform v1.0.7
on linux_amd64
Configuring remote state backend...
Initializing Terraform configuration...
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 5:
│    5: variable "aws_eks_cluster_primary_security_group_id" {
│ 
│ The root module input variable "aws_eks_cluster_primary_security_group_id"
│ is not set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 22:
│   22: variable "aws_region" {
│ 
│ The root module input variable "aws_region" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 27:
│   27: variable "aws_secretsmanager_account_id" {
│ 
│ The root module input variable "aws_secretsmanager_account_id" is not set,
│ and has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 32:
│   32: variable "aws_vpc_id" {
│ 
│ The root module input variable "aws_vpc_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 37:
│   37: variable "aws_vpc_private_subnets" {
│ 
│ The root module input variable "aws_vpc_private_subnets" is not set, and
│ has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 42:
│   42: variable "aws_vpc_public_subnets" {
│ 
│ The root module input variable "aws_vpc_public_subnets" is not set, and has
│ no default value. Use a -var or -var-file command line argument to provide
│ a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 60:
│   60: variable "eks_cluster_name" {
│ 
│ The root module input variable "eks_cluster_name" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 65:
│   65: variable "kubeflow_cluster_oidc_provider_arn" {
│ 
│ The root module input variable "kubeflow_cluster_oidc_provider_arn" is not
│ set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 69:
│   69: variable "route53_subdomain" {
│ 
│ The root module input variable "route53_subdomain" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 74:
│   74: variable "stage" {
│ 
│ The root module input variable "stage" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

Pusher: @jai, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub Actions

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/honestbank/argoflow-aws-infrastructure/runs/run-5noVdZm2pysKNGBf

Waiting for the plan to start...

Terraform v1.0.7
on linux_amd64
Configuring remote state backend...
Initializing Terraform configuration...
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 5:
│    5: variable "aws_eks_cluster_primary_security_group_id" {
│ 
│ The root module input variable "aws_eks_cluster_primary_security_group_id"
│ is not set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 22:
│   22: variable "aws_region" {
│ 
│ The root module input variable "aws_region" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 27:
│   27: variable "aws_secretsmanager_account_id" {
│ 
│ The root module input variable "aws_secretsmanager_account_id" is not set,
│ and has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 32:
│   32: variable "aws_vpc_id" {
│ 
│ The root module input variable "aws_vpc_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 37:
│   37: variable "aws_vpc_private_subnets" {
│ 
│ The root module input variable "aws_vpc_private_subnets" is not set, and
│ has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 42:
│   42: variable "aws_vpc_public_subnets" {
│ 
│ The root module input variable "aws_vpc_public_subnets" is not set, and has
│ no default value. Use a -var or -var-file command line argument to provide
│ a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 60:
│   60: variable "eks_cluster_name" {
│ 
│ The root module input variable "eks_cluster_name" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 65:
│   65: variable "kubeflow_cluster_oidc_provider_arn" {
│ 
│ The root module input variable "kubeflow_cluster_oidc_provider_arn" is not
│ set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 69:
│   69: variable "route53_subdomain" {
│ 
│ The root module input variable "route53_subdomain" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 74:
│   74: variable "stage" {
│ 
│ The root module input variable "stage" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

Pusher: @jai, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub Actions

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/honestbank/argoflow-aws-infrastructure/runs/run-9Jf9XPf9VAcWvP9p

Waiting for the plan to start...

Terraform v1.0.7
on linux_amd64
Configuring remote state backend...
Initializing Terraform configuration...
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 5:
│    5: variable "aws_eks_cluster_primary_security_group_id" {
│ 
│ The root module input variable "aws_eks_cluster_primary_security_group_id"
│ is not set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 22:
│   22: variable "aws_region" {
│ 
│ The root module input variable "aws_region" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 27:
│   27: variable "aws_secretsmanager_account_id" {
│ 
│ The root module input variable "aws_secretsmanager_account_id" is not set,
│ and has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 32:
│   32: variable "aws_vpc_id" {
│ 
│ The root module input variable "aws_vpc_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 37:
│   37: variable "aws_vpc_private_subnets" {
│ 
│ The root module input variable "aws_vpc_private_subnets" is not set, and
│ has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 42:
│   42: variable "aws_vpc_public_subnets" {
│ 
│ The root module input variable "aws_vpc_public_subnets" is not set, and has
│ no default value. Use a -var or -var-file command line argument to provide
│ a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 60:
│   60: variable "eks_cluster_name" {
│ 
│ The root module input variable "eks_cluster_name" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 65:
│   65: variable "kubeflow_cluster_oidc_provider_arn" {
│ 
│ The root module input variable "kubeflow_cluster_oidc_provider_arn" is not
│ set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 69:
│   69: variable "route53_subdomain" {
│ 
│ The root module input variable "route53_subdomain" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 74:
│   74: variable "stage" {
│ 
│ The root module input variable "stage" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

Pusher: @jai, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub Actions

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/honestbank/argoflow-aws-infrastructure/runs/run-NQdcEuT2Myvi9uuD

Waiting for the plan to start...

Terraform v1.0.7
on linux_amd64
Configuring remote state backend...
Initializing Terraform configuration...
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 5:
│    5: variable "aws_eks_cluster_primary_security_group_id" {
│ 
│ The root module input variable "aws_eks_cluster_primary_security_group_id"
│ is not set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 22:
│   22: variable "aws_region" {
│ 
│ The root module input variable "aws_region" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 27:
│   27: variable "aws_secretsmanager_account_id" {
│ 
│ The root module input variable "aws_secretsmanager_account_id" is not set,
│ and has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 32:
│   32: variable "aws_vpc_id" {
│ 
│ The root module input variable "aws_vpc_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 37:
│   37: variable "aws_vpc_private_subnets" {
│ 
│ The root module input variable "aws_vpc_private_subnets" is not set, and
│ has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 42:
│   42: variable "aws_vpc_public_subnets" {
│ 
│ The root module input variable "aws_vpc_public_subnets" is not set, and has
│ no default value. Use a -var or -var-file command line argument to provide
│ a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 60:
│   60: variable "eks_cluster_name" {
│ 
│ The root module input variable "eks_cluster_name" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 65:
│   65: variable "kubeflow_cluster_oidc_provider_arn" {
│ 
│ The root module input variable "kubeflow_cluster_oidc_provider_arn" is not
│ set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 69:
│   69: variable "route53_subdomain" {
│ 
│ The root module input variable "route53_subdomain" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 74:
│   74: variable "stage" {
│ 
│ The root module input variable "stage" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

Pusher: @jai, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub Actions

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/honestbank/argoflow-aws-infrastructure/runs/run-1Jz5gisZEy5R9QVR

Waiting for the plan to start...

Terraform v1.0.7
on linux_amd64
Configuring remote state backend...
Initializing Terraform configuration...
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 5:
│    5: variable "aws_eks_cluster_primary_security_group_id" {
│ 
│ The root module input variable "aws_eks_cluster_primary_security_group_id"
│ is not set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 22:
│   22: variable "aws_region" {
│ 
│ The root module input variable "aws_region" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 27:
│   27: variable "aws_secretsmanager_account_id" {
│ 
│ The root module input variable "aws_secretsmanager_account_id" is not set,
│ and has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 32:
│   32: variable "aws_vpc_id" {
│ 
│ The root module input variable "aws_vpc_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 37:
│   37: variable "aws_vpc_private_subnets" {
│ 
│ The root module input variable "aws_vpc_private_subnets" is not set, and
│ has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 42:
│   42: variable "aws_vpc_public_subnets" {
│ 
│ The root module input variable "aws_vpc_public_subnets" is not set, and has
│ no default value. Use a -var or -var-file command line argument to provide
│ a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 60:
│   60: variable "eks_cluster_name" {
│ 
│ The root module input variable "eks_cluster_name" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 65:
│   65: variable "kubeflow_cluster_oidc_provider_arn" {
│ 
│ The root module input variable "kubeflow_cluster_oidc_provider_arn" is not
│ set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 69:
│   69: variable "route53_subdomain" {
│ 
│ The root module input variable "route53_subdomain" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 74:
│   74: variable "stage" {
│ 
│ The root module input variable "stage" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

Pusher: @jai, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub Actions

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

Terraform Plan 📖failure

Show Plan

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

To view this run in a browser, visit:
https://app.terraform.io/app/honestbank/argoflow-aws-infrastructure/runs/run-Ff9WBcRabNj7tRCj

Waiting for the plan to start...

Terraform v1.0.7
on linux_amd64
Configuring remote state backend...
Initializing Terraform configuration...
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 5:
│    5: variable "aws_eks_cluster_primary_security_group_id" {
│ 
│ The root module input variable "aws_eks_cluster_primary_security_group_id"
│ is not set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 22:
│   22: variable "aws_region" {
│ 
│ The root module input variable "aws_region" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 27:
│   27: variable "aws_secretsmanager_account_id" {
│ 
│ The root module input variable "aws_secretsmanager_account_id" is not set,
│ and has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 32:
│   32: variable "aws_vpc_id" {
│ 
│ The root module input variable "aws_vpc_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 37:
│   37: variable "aws_vpc_private_subnets" {
│ 
│ The root module input variable "aws_vpc_private_subnets" is not set, and
│ has no default value. Use a -var or -var-file command line argument to
│ provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 42:
│   42: variable "aws_vpc_public_subnets" {
│ 
│ The root module input variable "aws_vpc_public_subnets" is not set, and has
│ no default value. Use a -var or -var-file command line argument to provide
│ a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 60:
│   60: variable "eks_cluster_name" {
│ 
│ The root module input variable "eks_cluster_name" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 65:
│   65: variable "kubeflow_cluster_oidc_provider_arn" {
│ 
│ The root module input variable "kubeflow_cluster_oidc_provider_arn" is not
│ set, and has no default value. Use a -var or -var-file command line
│ argument to provide a value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 69:
│   69: variable "route53_subdomain" {
│ 
│ The root module input variable "route53_subdomain" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on inputs.tf line 74:
│   74: variable "stage" {
│ 
│ The root module input variable "stage" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵

Pusher: @jai, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub Actions

[MXfive]

Local exec provisioner to run an atomic password changing script via a null resource that depends on this kubeflow_db resource is I think the cleanest way.