Skip to content

Conversation

@rkuris
Copy link

@rkuris rkuris commented Dec 8, 2025

Added additional attributes

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).

  • Adjusted missing or incorrect information in the current documentation (current branch).

  • Added documentation for a new integration I'm adding to Home Assistant (next branch).

  • Added documentation for a new feature I'm adding to Home Assistant (next branch).

  • Removed stale or deprecated documentation.

  • Adding documentation for new attributes in an existing integration.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Added additional attributes
Copilot AI review requested due to automatic review settings December 8, 2025 07:15
@home-assistant home-assistant bot added the current This PR goes into the current branch label Dec 8, 2025
@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 198a860
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/69367b1610c1c6000871b604
😎 Deploy Preview https://deploy-preview-42399--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@home-assistant home-assistant bot added the has-parent This PR has a parent PR in another repo label Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for newly exposed attributes in the NOAA Tides integration. The update provides users with detailed information about the available attributes for the sensor.noaa_tides entity, including timing and height information for upcoming tide events.

Key changes:

  • Added a new "Entities and Attributes" section to document the sensor's attributes
  • Documented nine attributes related to tide event timing and measurements
  • Included a clarifying note about the relationship between low and high tide times


## Entities and Attributes

This plugin exposes one entity `sensor.noaa_tides` which has a native value that contains the next tide event
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'plugin' with 'integration' to align with Home Assistant terminology. Home Assistant uses 'integration' to refer to its components.

Copilot generated this review using guidance from repository custom instructions.

| Attribute | Description
| --------- | -----------
| next_tide_event_time | Minute of next tide event in %Y-%m-%dT%H:%M format, in the timezone as configured above |
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description says 'Minute of next tide event' but should be 'Time of next tide event' since the format includes date, hour, and minute information, not just the minute.

Suggested change
| next_tide_event_time | Minute of next tide event in %Y-%m-%dT%H:%M format, in the timezone as configured above |
| next_tide_event_time | Time of next tide event in %Y-%m-%dT%H:%M format, in the timezone as configured above |

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is clearer.


| Attribute | Description
| --------- | -----------
| next_tide_event_time | Minute of next tide event in %Y-%m-%dT%H:%M format, in the timezone as configured above |
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datetime format should be described using natural language instead of format codes. Consider: 'Time of next tide event in ISO 8601 format (YYYY-MM-DDTHH:MM), in the configured timezone'.

Suggested change
| next_tide_event_time | Minute of next tide event in %Y-%m-%dT%H:%M format, in the timezone as configured above |
| next_tide_event_time | Time of next tide event in ISO 8601 format (YYYY-MM-DDTHH:MM), in the configured timezone |

Copilot uses AI. Check for mistakes.
This plugin exposes one entity `sensor.noaa_tides` which has a native value that contains the next tide event
information as a string, formatted as "[High|Low] tide at H:MM AM/PM". There are additional attributes that can
be used for display or automation as follows:

Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line before the table to ensure proper Markdown rendering across different parsers.

Suggested change

Copilot uses AI. Check for mistakes.
@jbouwh
Copy link
Contributor

jbouwh commented Dec 8, 2025

Seems this is related to an open PR in Core. Please. Start a fresh new PR and target this against the next branch. And link the core PR.

@jbouwh jbouwh marked this pull request as draft December 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants