Skip to content

Conversation

@MattieGit
Copy link

@MattieGit MattieGit commented Jan 7, 2026

Proposed change

This PR adds a new integration for Qube Heat Pumps.
It supports checking the status and controlling Qube heat pumps via Modbus TCP.

Features:

  • Configuration via UI (config flow).
  • Supports auto-discovery.
  • Sensors for temperatures (inlet, outlet, buffer), flow rate, and power.
  • Binary sensors for state (pump active, compressor active, etc.).
  • Switches/Controls for changing mode.
  • Quality Scale: Silver (Strict typing, no I/O in event loop, proper config flow, dynamic entity management).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MattieGit

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft January 7, 2026 10:24
@home-assistant
Copy link

home-assistant bot commented Jan 7, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matt-WL

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MattieGit MattieGit marked this pull request as ready for review January 7, 2026 17:27
@home-assistant home-assistant bot dismissed stale reviews from themself January 7, 2026 17:27

Stale

@home-assistant home-assistant bot marked this pull request as draft January 7, 2026 22:38
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matt-WL

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MattieGit MattieGit marked this pull request as ready for review January 8, 2026 09:27
@home-assistant home-assistant bot requested a review from joostlek January 8, 2026 09:28
@MattieGit
Copy link
Author

Hello 👋🏻 @joostlek!

Services and diagnostics have been removed.
Device specific code has been moved to a library.
Let me know if any other updates are required. This integration is based on my existing HACS integration for the Qube heat pump, so I had to remove a lot of existing functionality (which also helped to improve code quality).

@joostlek
Copy link
Member

joostlek commented Jan 8, 2026

Did you not push yet? The code still seems to directly call pymodbus instead of a library

@joostlek joostlek marked this pull request as draft January 8, 2026 12:06
@MattieGit
Copy link
Author

Did you not push yet? The code still seems to directly call pymodbus instead of a library

My bad! Updated now!

@MattieGit MattieGit marked this pull request as ready for review January 8, 2026 13:54
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll push back again

What we expect from a library is that they abstract away the device specific things. So instead of ask the modbus library to read register x to get the temperature, I want the library to return me the relevant data. We currently also load all the registers from a yaml file? That's also something that we shouldn't do

@home-assistant home-assistant bot marked this pull request as draft January 8, 2026 14:01
@MattieGit
Copy link
Author

You're completely right. I've made the requested changes and removed more legacy code.

@MattieGit MattieGit marked this pull request as ready for review January 8, 2026 17:46
@home-assistant home-assistant bot requested a review from joostlek January 8, 2026 17:47
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you have a proper development environment.

@home-assistant home-assistant bot marked this pull request as draft January 8, 2026 18:05
@MattieGit
Copy link
Author

Apologies and thank you for the patience. Dev environment should be fixed now.

@MattieGit MattieGit marked this pull request as ready for review January 8, 2026 20:23
@home-assistant home-assistant bot requested a review from joostlek January 8, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants