Repository navigation
Add Qube Heat Pump integration - #160409
Merged
Merged
Conversation
home-assistant
Bot
added
cla-needed
has-tests
new-integration
integration: qube_heatpump
labels
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hi @MattieGit
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
This was referenced Jan 7, 2026
MattieGit
force-pushed
the
add-qube-heatpump
branch
from
January 7, 2026 15:37
57c976e to
c5d97b1
Compare
MattieGit
marked this pull request as ready for review
January 7, 2026 17:27
Removed "hass" from codespell ignore list. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…pellrc Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joostlek
requested changes
Mar 19, 2026
|
|
||
| from homeassistant.const import Platform | ||
|
|
||
| DOMAIN = "qube_heatpump" |
Member
There was a problem hiding this comment.
Oh this is not about mDNS, more about the integration. Generally we try to pick a good domain as we can't change it afterwards. Let me also ask for other opinions
joostlek
requested changes
Mar 19, 2026
- Remove MAC address lookup, use _async_abort_entries_match instead - Remove monotonic clamping (moved to library v1.6.3) - Use entry_id for device identifiers and entity unique_ids - Combine client fixtures (mealie pattern) - Parametrize config flow error tests with recovery - Replace individual sensor tests with snapshot_platform - Move coordinator error tests to sensor tests - Combine setup/unload into single init test - Bump library requirement to 1.6.3
Member
|
Do you have discord and can you send me a message? |
Rename integration domain and folder to "hr_energy_qube" as discussed with @joostlek. Config entry title has also been updated to sentence case ("Qube heat pump") and step title has been removed based on hassfest validation feedback.
joostlek
approved these changes
Mar 24, 2026
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds a new integration for Qube Heat Pumps.
It supports monitoring Qube heat pumps via Modbus TCP.
Features:
Type of change
Additional information
Checklist