-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Add Qube Heat Pump integration #160409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add Qube Heat Pump integration #160409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MattieGit
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
57c976e to
c5d97b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
66133b4 to
a5d90b0
Compare
|
Hello 👋🏻 @joostlek! Services and diagnostics have been removed. |
|
Did you not push yet? The code still seems to directly call |
My bad! Updated now! |
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'll push back again
What we expect from a library is that they abstract away the device specific things. So instead of ask the modbus library to read register x to get the temperature, I want the library to return me the relevant data. We currently also load all the registers from a yaml file? That's also something that we shouldn't do
|
You're completely right. I've made the requested changes and removed more legacy code. |
joostlek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you have a proper development environment.
f4753f7 to
f0b78b5
Compare
|
Apologies and thank you for the patience. Dev environment should be fixed now. |
Proposed change
This PR adds a new integration for Qube Heat Pumps.
It supports checking the status and controlling Qube heat pumps via Modbus TCP.
Features:
Type of change
Additional information
Checklist