Skip to content

Conversation

@farkasdi
Copy link
Contributor

@farkasdi farkasdi commented Jan 6, 2026

Proposed change

The change is refactoring binary_sensor.py in netatmo to allow further binary_sensor addition. It follows the method of sensor definition in sensor.py.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 6, 2026

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (netatmo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netatmo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign netatmo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@farkasdi farkasdi force-pushed the netatmo_binary_sensor-refactor branch from d49fadd to ff09c55 Compare January 6, 2026 08:38
@epenet epenet changed the title netatmo: binary_sensor refactoring Refactor netatmo binary sensors Jan 6, 2026
@farkasdi farkasdi force-pushed the netatmo_binary_sensor-refactor branch from e797f3a to 71e17de Compare January 7, 2026 10:44
@farkasdi farkasdi requested a review from emontnemery January 7, 2026 11:06
@farkasdi
Copy link
Contributor Author

farkasdi commented Jan 7, 2026

Logging has been reduced.

@farkasdi farkasdi requested a review from emontnemery January 7, 2026 14:20
@farkasdi farkasdi force-pushed the netatmo_binary_sensor-refactor branch from 74900f7 to 56419ec Compare January 8, 2026 08:56
@farkasdi farkasdi requested a review from emontnemery January 8, 2026 09:01
@farkasdi farkasdi requested a review from emontnemery January 8, 2026 11:48
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @farkasdi 👍

@emontnemery emontnemery merged commit 33d1cdd into home-assistant:dev Jan 8, 2026
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants