-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Add additional lens modes 4 to 10 to JVC projector remote #159657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add support to modes 4 to 10 My pull request to the library must be merged before SteveEasley/pyjvcprojector#7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @momala454
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @SteveEasley, @msavazzi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Curious as well, is there a way to get the state for this? Because this'd be a really nice number or select entity which makes it easy to use |
|
I have been working on a massive upgrade to pyjvcprojector for a couple of weeks that would include this feature as well as a ton of others. All implemented as sensors/selects. |
|
@momala454 Your pyjvcprojector contribution is live in https://pypi.org/project/pyjvcprojector/1.1.3/. So now you just need to update the manifest.json file in your HA PR to use |
|
Please add the diff of the new version to the PR description |
|
@momala454 Your PR is failing checks because you need to run |
i am not really familiar with this, are you able to do it please ? |
|
thanks @joostlek and @SteveEasley :) |
|
@SteveEasley said he was working on that new version with more controls and whatnot. It would be very cool if you kept an eye open to the changes he's going to make and if you're willing to test them :) |
|
Yes but i think i would need it on hacs to easily test it thanks |
Add support to modes 4 to 10
My pull request to the library must be merged before SteveEasley/pyjvcprojector#7
An issue was already opened here #147178
updated library : SteveEasley/pyjvcprojector@v1.1.2...v1.1.3
Breaking change
Proposed change
Add support to additionnal lens modes 4 to 10 instead of just 1-3
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: