Skip to content

Conversation

@momala454
Copy link
Contributor

@momala454 momala454 commented Dec 23, 2025

Add support to modes 4 to 10
My pull request to the library must be merged before SteveEasley/pyjvcprojector#7

An issue was already opened here #147178

updated library : SteveEasley/pyjvcprojector@v1.1.2...v1.1.3

Breaking change

Proposed change

Add support to additionnal lens modes 4 to 10 instead of just 1-3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Add support to modes 4 to 10
My pull request to the library must be merged before SteveEasley/pyjvcprojector#7
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @momala454

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 23, 2025 20:41
@home-assistant
Copy link

Hey there @SteveEasley, @msavazzi, mind taking a look at this pull request as it has been labeled with an integration (jvc_projector) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jvc_projector can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jvc_projector Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@momala454 momala454 changed the title Add additional lens modes to JVC projector remote Add additional lens modes 4 to 10 to JVC projector remote Dec 23, 2025
@momala454 momala454 marked this pull request as ready for review December 23, 2025 20:43
@joostlek
Copy link
Member

Curious as well, is there a way to get the state for this? Because this'd be a really nice number or select entity which makes it easy to use

@SteveEasley
Copy link
Contributor

I have been working on a massive upgrade to pyjvcprojector for a couple of weeks that would include this feature as well as a ton of others. All implemented as sensors/selects.

@joostlek joostlek marked this pull request as draft December 29, 2025 14:20
@SteveEasley
Copy link
Contributor

@momala454 Your pyjvcprojector contribution is live in https://pypi.org/project/pyjvcprojector/1.1.3/. So now you just need to update the manifest.json file in your HA PR to use 1.1.3.

@momala454 momala454 marked this pull request as ready for review January 6, 2026 23:22
@joostlek
Copy link
Member

joostlek commented Jan 6, 2026

Please add the diff of the new version to the PR description

@SteveEasley
Copy link
Contributor

@SteveEasley
Copy link
Contributor

@momala454 Your PR is failing checks because you need to run python3 -m script.gen_requirements_all (see here) inside a working HA python environment.

@momala454
Copy link
Contributor Author

@momala454 Your PR is failing checks because you need to run python3 -m script.gen_requirements_all (see here) inside a working HA python environment.

i am not really familiar with this, are you able to do it please ?

@joostlek joostlek merged commit 7b0463f into home-assistant:dev Jan 7, 2026
63 checks passed
@momala454
Copy link
Contributor Author

thanks @joostlek and @SteveEasley :)

@joostlek
Copy link
Member

joostlek commented Jan 7, 2026

@SteveEasley said he was working on that new version with more controls and whatnot. It would be very cool if you kept an eye open to the changes he's going to make and if you're willing to test them :)

@momala454
Copy link
Contributor Author

Yes but i think i would need it on hacs to easily test it thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set higher lens memory for JVC Projector integration

3 participants