-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Add new Home Connect washing machine programs #157174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Home Connect washing machine programs #157174
Conversation
|
Hey there @DavidMStraub, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Awaiting for aiohomeconnect to be updated MartinHjelmare/aiohomeconnect#113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for three new Home Connect washing machine programs reported by a user: "Hygiene", "Rinse", and "Spin/drain". The changes also reorganize the washing machine programs in services.yaml into alphabetical order for better maintainability.
- Adds three new washing machine program options to the Home Connect integration
- Alphabetizes all washer programs in services.yaml
- Updates translation strings consistently across all required sections
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/home_connect/strings.json | Adds three new washer program translations (hygiene_plus, rinse, spin_drain) to active_program, selected_program, and programs selector sections with proper translation key references |
| homeassistant/components/home_connect/services.yaml | Alphabetizes washer programs and includes the three new programs in the set_program_and_options service definition |
Proposed change
Add new programs that were reported by @zavjah at #157157
Also made some shortening at services.yaml for washer programs.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: