Skip to content

fixed bug in membership test_function #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug in membership test_function #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ToricSheaves/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SetPackageInfo( rec(

PackageName := "ToricSheaves",
Subtitle := "Toric sheaves as Serre quotients",
Version := "2020.10-01",
Version := "2021.02-01",
Date := Concatenation( "01/", ~.Version{[ 6, 7 ]}, "/", ~.Version{[ 1 .. 4 ]} ),
License := "GPL-2.0-or-later",

Expand Down
11 changes: 6 additions & 5 deletions ToricSheaves/examples/Hirzebruch7.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,15 @@ CohH7 := CategoryOfToricSheaves( H7 );

S := CoxRing( H7 );

Mirr := HomalgMatrix( "[x_3*x_4,x_1*x_4,x_1*x_2,x_2*x_3]",4,1,S );

gen_degs := DegreesOfGenerators( IrrelevantIdeal( H7 ) );

Irrel := AsGradedLeftPresentation( Mirr );
## A module supported on the irrelevant locus
Mirr := AsGradedLeftPresentation( HomalgMatrix( "[x_1*x_2, x_1*x_3, x_2*x_4, x_3*x_4]", 4, 1, S ) );

SheafMirr := AsSerreQuotientCategoryObject( CohH7, Mirr );

SheafIrrel := AsSerreQuotientCategoryObject( CohH7, Irrel );
Assert( 0, IsZero( SheafMirr ) );

MS := AsGradedLeftPresentation( FreeLeftPresentation( 1, S ) );
MS := GradedFreeLeftPresentation( 1, S );

SheafS := AsSerreQuotientCategoryObject( CohH7, MS );
2 changes: 1 addition & 1 deletion ToricSheaves/gap/ToricSheaves.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ InstallMethod( CategoryOfToricSheaves,

presentation_category := GradedLeftPresentations( graded_ring );

if IsFree( DegreeGroup( graded_ring ) ) and ForAll( degree_matrix_as_list_list, i -> ForAll( i, j -> j >= 0 ) ) and comes_from_smooth_variety then
if IsFree( DegreeGroup( graded_ring ) ) and Rank( DegreeGroup( graded_ring ) ) = 1 and ForAll( degree_matrix_as_list_list, i -> ForAll( i, j -> j >= 0 ) ) and comes_from_smooth_variety then

test_function := module -> IsZero( HilbertPolynomial( UnderlyingMatrixOverNonGradedRing( UnderlyingMatrix( module ) ) ) );

Expand Down