Forward allowPush and pushOnly options to core#138
Merged
Conversation
| eagerUpgrade: true, | ||
| notDownloadingLinger: opts.notDownloadingLinger, | ||
| allowFork: opts.allowFork !== false, | ||
| allowPush: !!opts.allowPush, |
Contributor
There was a problem hiding this comment.
Curious why is allowPush truthy vs pushOnly explicitly needs true. Currently the are both coerced to truthy in hypercore.
Contributor
Author
There was a problem hiding this comment.
it's a good point, made me dig in a bit and I remembered the pushOnly option is actually passed via the session opts and then set here: https://github.com/holepunchto/hypercore/blob/main/index.js#L350
Contributor
Author
There was a problem hiding this comment.
in the end, i realised it's actually just the allowPush option that was missing, so have updated the PR
lejeunerenard
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.