Added command result types and error handling.#39
Open
bveldhoen wants to merge 3 commits intohmartiro:masterfrom
Open
Added command result types and error handling.#39bveldhoen wants to merge 3 commits intohmartiro:masterfrom
bveldhoen wants to merge 3 commits intohmartiro:masterfrom
Conversation
Without this fix, a segv will happen in certain error conditions where the reply_obj == nullptr.
Owner
|
Hi, could you upload a new change (perhaps revert the rpm name commit) so that travis can run on this PR? |
Owner
|
Hi, please see my note in the README if you are interested. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new result types are used for processing the sentinel commands (such as sentinel masters, sentinel slaves). Unit tests for these new types were added too.
Added error handling and nullptr checks for the reply.