-
Notifications
You must be signed in to change notification settings - Fork 1
Update build #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update build #13
Conversation
Don't limit the parallel setting in the configuration. Let the build system take care of the optimal parallel jobs.
Make build.sh ninja and cmake commands run in top level working directory. Let build.sh fail when a subcommand fails.
|
I think the things missing from #12 are the attributes and the bytecode output @widlarizer? |
|
Sorry, I don't understand the plan. Is this #12 rebased but you removed some things so they're missing now? |
|
Right, so the CIRCT bump includes none of the actual CIRCT changes, I'll see when I can get to rebase all that then |
|
The CIRCT bump should include the existing RTLIL stuff with some rebase adoptions, but none of the change from you fork. |
|
I see, thanks. Is this PR buildable as-is? I tried moving all of #12 on top of this PR but ran into: Which seems quite unrelated to any of the changes I did. But also I may have messed up the rebase. You can look at that rebase here |
|
I tested the PR before I opened it. It should work... |
|
I rechecked without any of my changes. Even if I have no nix flake bump, with this PR as-is, I still get the same build error when clean building. I don't know what's up with that yet |
@widlarizer, I reused some of your commits (also merged a few things together) from #12
My goal would be to bring this up-to-date, and then also have the changes in CIRCT which we also want to have upstream, and maybe leave out the "experimental" things.
So updating the build in here, and then follow up with the features in another PR.