perf(s3): use spawn-based fetcher for S3 block source#125
Merged
sprites0 merged 1 commit intonode-builderfrom Mar 16, 2026
Merged
perf(s3): use spawn-based fetcher for S3 block source#125sprites0 merged 1 commit intonode-builderfrom
sprites0 merged 1 commit intonode-builderfrom
Conversation
383de5f to
6aac87b
Compare
6f5f9d1 to
f443875
Compare
f443875 to
c4b9d10
Compare
c4b9d10 to
c7944fd
Compare
c7944fd to
7ef573f
Compare
Override collect_blocks on S3BlockSource with tokio::spawn batches instead of the default buffered() stream. This avoids the single-task polling bottleneck and yields ~10x speedup on fast networks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7ef573f to
92eb71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect_blocksonS3BlockSourcewithtokio::spawnbatches instead of the defaultbuffered()streambuffered()as the default trait impl (better for filesystem and other sources)buffered()ortokio::spawnTest plan
buffered())🤖 Generated with Claude Code