Skip to content

Conversation

@pizzi80
Copy link

@pizzi80 pizzi80 commented Aug 29, 2024

Hi, this is my contribution to the project 💣 😄

  • Fixed Maven pom.xml
  • Fixed some bugs / improved minor things
  • Removed Spring Dependency
  • Upgrade to Apache Common Langs 3
  • Upgrade to Flying Saucer 9
  • Upgrade to Neko HtmlUnit 1.9.22
  • Upgrade to Junit 5
  • Minimum Java version 17
  • All tests now write to an output directory "output"
  • Add an "html5" doctype test
  • Add a test for div with display inline-block

Signed-off-by: pizzi80 <[email protected]>
Signed-off-by: pizzi80 <[email protected]>
Signed-off-by: pizzi80 <[email protected]>
Signed-off-by: pizzi80 <[email protected]>
Signed-off-by: pizzi80 <[email protected]>
Signed-off-by: pizzi80 <[email protected]>
- Upgrade to NekoHtml 1.9.22
- CustomizableFSImageWriter extends the default FS Image writer
- Added "html5" test

Signed-off-by: pizzi80 <[email protected]>
@hkirk
Copy link
Owner

hkirk commented Aug 30, 2024

Nice job will try to look at this weekend, but seems like a very meticolous PR

@pizzi80
Copy link
Author

pizzi80 commented Aug 30, 2024

Thanks! I tried my best 😅

I'm writing you some more notes because when I did the PR(s)
it was late and I was fighting with jitpack ... 😠

At first I made a PR with HtmlUnit 4.x But after a second review
I realized that it doesn't support many html/css "stuff",
so I went back to 1.9.latest, which seems to work quite well
although it's not perfect because it doesn't support the "latest" css techniques,
"flex" for example...

JPG rendering is always so-so in java, at the moment the quality seems decent,
I should try with TwelveMonkeys to see if it improves, but in my opinion
it's not worth putting it as a dependency because
if you want you can always add it to the project as you like
(eg. system library, Tomcat lib, webapp lib, ... )
and it's transparent for the developer ...

Last but not least, sorry for the changes to the "imports" but my ide
is configured as required for some Jakarta EE Projects I contribute to
and they are very serious about it... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants