Update to hspline and lowess filters.#69
Open
talensgj wants to merge 8 commits into
Open
Conversation
Owner
|
Hi, Thank you for your proposed changes! For each of them I have some questions. Let's start with the easiest ones: |
Author
|
@hippke I used cval=3 in my work, because in my tests cval=1.35 seemed a bit aggressive. The current state of the PR still has the value at cval=1.35, I have merely made it so the user can change it if they want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've made some modifications to the hspline and lowess filters, specifically:
hspline
lowess
I hope you will find these changes make sense and merge them into wotan.