Moderation logs #326
Moderation logs #326
Conversation
|
Тести не пройшли через не до кінця видалену роль ROLE_RESTRICTED |
Можна знов залити зміни з |
|
@kuyugama Тепер немає конфліктів, буду вдячний якщо зробиш code review |
| "bad-backup-token": ["Bad backup token", 401], | ||
| }, | ||
| "moderation-log": { | ||
| "no-access": ["You do not have permission to access", 400], |
There was a problem hiding this comment.
There are permission check in auth_requied dependency with its permission error, why creating new?
| async def validate_moderation_role( | ||
| author: User = Depends(auth_required(optional=False)), | ||
| ): | ||
| if author.role not in ["admin", "moderator"]: |
There was a problem hiding this comment.
Instead of checking roles, you should add permission and check by it using auth_required. If you need custom error, you can add parameter for it into auth_required
| async def get_edit(session, content_id): | ||
| return await session.scalar(select(Edit).filter(Edit.id == content_id)) | ||
|
|
||
|
|
||
| async def get_comment(session, content_id): | ||
| return await session.scalar( | ||
| select(Comment).filter(Comment.id == content_id) | ||
| ) | ||
|
|
||
|
|
||
| async def get_collection(session, content_id): | ||
| return await session.scalar( | ||
| select(Collection).filter(Collection.id == content_id) | ||
| ) |
There was a problem hiding this comment.
You need to load author fields using options method on select query object
3 participants
Генерує логи модерації
Tasklist