add English translated character name if Ukrainian one exists #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebbaited
changed the title
kuyugama
requested changes
Feb 7, 2025
Member
kuyugama
left a comment
kuyugama
left a comment
There was a problem hiding this comment.
If person or character object does not have name_en field set, other languages field would contain invalid value
| const otherLanguagesName = | ||
| name === character.name_en | ||
| ? character.name_ja | ||
| : `${character.name_ja} / ${character.name_en}`; |
Member
There was a problem hiding this comment.
What if there is no name_en in character object? It would be "{name_ja} / {''}"
|
|
||
| const name = person.name_ua || person.name_en || person.name_native; | ||
| const otherLanguagesName = | ||
| name === person.name_en |
Member
There was a problem hiding this comment.
What if there is no name_en in person object? It would be "{name_native} / {''}"
kuyugama
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Картка https://trello.com/c/l3YTK9Ig