fix(yaml) - correct escaping behavior in single-quoted YAML strings #4159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +38 B View Changes
|
joshgoebel
reviewed
Nov 5, 2024
joshgoebel
reviewed
Nov 5, 2024
Member
|
Lets also make sure we add a single quote escaping to our markup tests - esp if we go with |
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +68 B View Changes
|
joshgoebel
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong escaping behavior in single-quoted strings
Resolves #4068
Changes
Before, backslashes in single-quoted strings were incorrectly treated as escape characters:
Now single-quoted strings follow YAML specification where only single quotes can be escaped (by doubling them):
Checklist
CHANGES.md