fixed the spacing issue in primary key and similar combos #4106
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +5 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change -1 B View Changes
|
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +3 B View Changes
|
|
Could you please test my iteration? It passes all your tests - as well as adding support for multi-word type modifiers also (for flexible spacing). |
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +17 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +10 B View Changes
|
i tested your code and it ran into problems as it started identifying comments as non-commented code |
|
ive made a commit regarding the fixes pls review @joshgoebel |
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +42 B View Changes
|
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +36 B View Changes
|
|
Simple typo... I think you're using another grammar entirely... here is what I have now: 
Looks right to me. |
Build Size ReportChanges to minified artifacts in 3 files changedTotal change -1 B View Changes
|
|
Now I'm thinking some of these should be types (since they modify the type), not keywords... such as: "primary key", |
apologies i changed to a different style and thought comment were being highlighted wrong |
|
So all good now? |
|
yes |
Build Size ReportChanges to minified artifacts in 3 files changedTotal change -3 B View Changes
|
2 participants
Resolves #4057
before
after
Checklist
CHANGES.md