Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements an audit logging system for identity lifecycle operations, including the creation of a new database table, repository, and service-level integration. The feedback focuses on ensuring the acting user's ID is consistently captured across all service methods (specifically within the agent service), standardizing audit timestamps to UTC, and expanding the logging logic to include failed operation attempts for a more comprehensive security trail.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identity mutations (create/update/delete) previously had no audit trail. Operators had no way to answer "who registered this agent?" or "who changed its trust level and when?".
owner_user_idis a static ownership field on the identity, not a record of who performed a given operation.This PR adds an
identity_audit_logstable that records every mutation with the acting user's ID (from the X-User-ID header, set by TenantContextMiddleware), a timestamp, and before/after JSONB snapshots of the identity row.Type of change
Testing
Impact / Risks
📸 Screenshots / Logs (if applicable)