chore: Various quality of life changes around CN <-> BN communication#25203
chore: Various quality of life changes around CN <-> BN communication#25203
Conversation
…d when a request is sent to the block node Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
…BUG; introduce cool down for behind block nodes Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 19 minor |
🟢 Metrics 9 complexity
Metric Results Complexity 9
🟢 Coverage 79.59% diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ 79.59% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (198285b) 100192 78875 78.72% Head commit (ba43a83) 100256 (+64) 78914 (+39) 78.71% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#25203) 147 117 79.59% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #25203 +/- ##
============================================
- Coverage 74.90% 74.88% -0.02%
Complexity 11524 11524
============================================
Files 2586 2586
Lines 100289 100353 +64
Branches 11087 11098 +11
============================================
+ Hits 75119 75149 +30
- Misses 21364 21389 +25
- Partials 3806 3815 +9
🚀 New features to boost your workflow:
|
… down to be percent based instead of a fixed number of blocks Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
4 file(s) changed in commit 69330e6
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Flaky Test(s) DetectedOne or more flaky tests were detected in this run. These tests have been reported before.
|
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Flaky Test(s) DetectedOne or more flaky tests were detected in this run. These tests have been reported before.
|
|
Passing XTS (BN Comms tests): https://github.com/hiero-ledger/hiero-consensus-node/actions/runs/25230279973 |
Description:
This PR introduces several changes to improve various parts of the CN/BN communication layer. Most of the changes are related to logging and otherwise not very impactful. The full changes include:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist