Skip to content

chore: Use nonce from evm result; use multipurpose contract in pectra batch …#25144

Open
lukasz-hashgraph wants to merge 1 commit intofeature/hedera-evm-pectra-supportfrom
chore/fix-blockstream-tests-pectra
Open

chore: Use nonce from evm result; use multipurpose contract in pectra batch …#25144
lukasz-hashgraph wants to merge 1 commit intofeature/hedera-evm-pectra-supportfrom
chore/fix-blockstream-tests-pectra

Conversation

@lukasz-hashgraph
Copy link
Copy Markdown
Contributor

@lukasz-hashgraph lukasz-hashgraph commented Apr 28, 2026

  • Simplify EthereumTransactionTranslator to use the nonce from evmResult (more reliable when there are delegations in reverted atomic batch transactions)
  • Use Multipurpose contract instead of Create in Pectra atomic batch tests (as a follow up we'll need to investigate why running hapiTestSmartContract locally produces errors when there are child creations in a reverted atomic batch)

…tests

Signed-off-by: Lukasz Gasior <lukasz.gasior@swirldslabs.com>
@lukasz-hashgraph lukasz-hashgraph requested review from a team as code owners April 28, 2026 12:25
@lukasz-hashgraph lukasz-hashgraph self-assigned this Apr 28, 2026
@lfdt-bot
Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@lukasz-hashgraph lukasz-hashgraph changed the title Use nonce from evm result; use multipurpose contract in pectra batch … chore: Use nonce from evm result; use multipurpose contract in pectra batch … Apr 28, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 28, 2026

Not up to standards ⛔

🔴 Issues 1 medium

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
ErrorProne 1 medium

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

🟢 Coverage ∅ diff coverage

Metric Results
Coverage variation Report missing for 2e18b111
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2e18b11) Report Missing Report Missing Report Missing
Head commit (c75d180) 100102 78841 78.76%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#25144) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@                         Coverage Diff                          @@
##             feature/hedera-evm-pectra-support   #25144   +/-   ##
====================================================================
  Coverage                                     ?   74.93%           
  Complexity                                   ?    11884           
====================================================================
  Files                                        ?     2585           
  Lines                                        ?   100199           
  Branches                                     ?    11044           
====================================================================
  Hits                                         ?    75086           
  Misses                                       ?    21310           
  Partials                                     ?     3803           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

⚠️ New Flaky Test(s) Detected — Action Required

New flaky tests were detected in this run. New tickets have been created and require your attention — please investigate whether the flakiness was introduced by changes in this PR.

Test Ticket
com.hedera.services.bdd.suites.contract.hapi.ContractCallSuite#callToNonExtantLongZeroAddressUsesTargetedAddress #25146 (🆕 New)
com.hedera.services.bdd.suites.contract.hapi.ContractCallSuite#hollowCreationFailsCleanly #25147 (🆕 New)
com.hedera.services.bdd.suites.contract.hapi.ContractCallSuite#repeatedCreate2FailsWithInterpretableActionSidecars #25148 (🆕 New)

Please review the linked tickets and determine if any of the new issues were caused by your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants