fix(yahcli): restore log output by bundling a dedicated log4j2 config#25131
Open
Chinnmay wants to merge 2 commits intohiero-ledger:mainfrom
Open
fix(yahcli): restore log output by bundling a dedicated log4j2 config#25131Chinnmay wants to merge 2 commits intohiero-ledger:mainfrom
Chinnmay wants to merge 2 commits intohiero-ledger:mainfrom
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
Chinnmay
force-pushed
the
fix-yahcli-log4j-config
branch
from
5e45c02 to
dad52ae
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #25131 +/- ##
=========================================
Coverage 74.92% 74.92%
Complexity 11525 11525
=========================================
Files 2587 2587
Lines 100289 100289
Branches 11088 11087 -1
=========================================
Hits 75137 75137
Misses 21342 21342
Partials 3810 3810 🚀 New features to boost your workflow:
|
15 tasks
mhess-swl
reviewed
Apr 27, 2026
Contributor
mhess-swl
left a comment
mhess-swl
left a comment
There was a problem hiding this comment.
Just had one thought, otherwise looks good!
Signed-off-by: chinnmay <sarvasvachaudhari55555@gmail.com>
… with <tc> Signed-off-by: chinnmay <sarvasvachaudhari55555@gmail.com>
Chinnmay
force-pushed
the
fix-yahcli-log4j-config
branch
from
8b9d8ca to
3d00e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yahcli was producing zero log output in preprod.
Root cause: The shadow jar bundles four
log4j2configs from transitive deps. Log4j2's auto-discovery picks the canonical filenamelog4j2.xml, which is the one shipped byswirlds-platform-core—and it sets
<Root level="off">.Fix
src/main/resources/log4j2-yahcli.xml— Console + RollingFile, rootINFO.src/main/resources/log4j2.component.properties— pins log4j2 to the new config.build.gradle.kts: exclude the four stale transitive configs (log4j2.xml,log4j2-test-client.xml,log4j2-JRS.xml,regression-log4j2.xml) from the shadow jar.No launcher/Dockerfile changes.