chore: Increase VirtualLeafBytes parse max size#24951
chore: Increase VirtualLeafBytes parse max size#24951derektriley wants to merge 5 commits intomainfrom
Conversation
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 2 minor |
| ErrorProne | 1 high |
🟢 Metrics 0 complexity
Metric Results Complexity 0
🟢 Coverage 100.00% diff coverage · +0.02% coverage variation
Metric Results Coverage variation ✅ +0.02% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (5277776) 99532 78342 78.71% Head commit (77ad317) 99537 (+5) 78362 (+20) 78.73% (+0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24951) 8 8 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
The code looks good to me as far as a call to PBJ is concerned.
However, it'd be nice if @imalygin and/or @artemananiev could take a look as well because they're experts in the VirtualMap implementation.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24951 +/- ##
============================================
+ Coverage 74.88% 74.90% +0.01%
- Complexity 11777 11780 +3
============================================
Files 2577 2577
Lines 99629 99634 +5
Branches 10959 10958 -1
============================================
+ Hits 74612 74631 +19
+ Misses 21237 21222 -15
- Partials 3780 3781 +1
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
7 file(s) changed in commit 56e6539
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
3 file(s) changed in commit 2ac219f
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
10 file(s) changed in commit b9fd3c8
Flaky Test(s) DetectedOne or more flaky tests were detected in this run. These tests have been reported before.
|
Description:
VirtualLeafBytes was updated to parse values with an explicit max-size limit because the default PBJ parse limit (2 MB) is too small for large HistoryProof payloads that can include uncompressed_wraps_proof (~31 MB at genesis). This caused deserialization to fail during state reads and triggered TSS reconciliation errors. Setting a bounded 36 MB limit keeps parsing safe while allowing valid large WRAPS proofs to be read from state.
Related issue(s):
Fixes #24934
Notes for reviewer:
Checklist