feat(24787): ffi & libsodium#24831
Conversation
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 8 medium 8 minor |
| ErrorProne | 5 high |
| CodeStyle | 26 minor |
| Complexity | 2 medium |
| Performance | 3 medium |
🟢 Metrics 72 complexity
Metric Results Complexity 72
🟢 Coverage 78.92% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 78.92% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (defefdc) 96878 78157 80.68% Head commit (74ebb01) 97005 (+127) 78260 (+103) 80.68% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24831) 166 131 78.92% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #24831 +/- ##
============================================
- Coverage 76.76% 76.75% -0.01%
- Complexity 11700 11739 +39
============================================
Files 2502 2505 +3
Lines 96975 97102 +127
Branches 10744 10760 +16
============================================
+ Hits 74444 74532 +88
- Misses 18768 18793 +25
- Partials 3763 3777 +14
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Related issue(s):
Fixes #24787