Skip to content

feat(24786): Reduce allocation rate sig validation#24828

Draft
mxtartaglia-sl wants to merge 2 commits intomainfrom
24786_reduce_allocation_rate_sig_validation
Draft

feat(24786): Reduce allocation rate sig validation#24828
mxtartaglia-sl wants to merge 2 commits intomainfrom
24786_reduce_allocation_rate_sig_validation

Conversation

@mxtartaglia-sl
Copy link
Copy Markdown
Contributor

Description:

Related issue(s):

Fixes #24786

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
@mxtartaglia-sl mxtartaglia-sl added this to the v0.74 milestone Apr 7, 2026
@mxtartaglia-sl mxtartaglia-sl self-assigned this Apr 7, 2026
@mxtartaglia-sl mxtartaglia-sl linked an issue Apr 7, 2026 that may be closed by this pull request
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 7, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@lfdt-bot
Copy link
Copy Markdown

lfdt-bot commented Apr 7, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 7, 2026

Not up to standards ⛔

🔴 Issues 7 medium · 18 minor

Alerts:
⚠ 25 issues (≤ 0 issues of at least minor severity)

Results:
25 new issues

Category Results
BestPractice 4 medium
8 minor
CodeStyle 10 minor
Performance 3 medium

View in Codacy

🟢 Metrics 47 complexity

Metric Results
Complexity 47

View in Codacy

🟢 Coverage 79.12% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage 79.12% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (defefdc) 96878 78157 80.68%
Head commit (68fc534) 96936 (+58) 78204 (+47) 80.68% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24828) 91 72 79.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

TIP This summary will be updated as you push new changes. Give us feedback

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 72.52747% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nsus/event/intake/utils/EventSignatureChecker.java 77.14% 11 Missing and 5 partials ⚠️
...g/hiero/consensus/crypto/internal/JcaVerifier.java 0.00% 4 Missing ⚠️
...ava/org/hiero/consensus/crypto/SigningFactory.java 0.00% 2 Missing ⚠️
...iero/consensus/crypto/internal/SodiumVerifier.java 0.00% 2 Missing ⚠️
...impl/signature/DefaultEventSignatureValidator.java 88.88% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #24828      +/-   ##
============================================
- Coverage     76.76%   76.75%   -0.01%     
- Complexity    11700    11737      +37     
============================================
  Files          2502     2504       +2     
  Lines         96975    97033      +58     
  Branches      10744    10748       +4     
============================================
+ Hits          74444    74482      +38     
- Misses        18768    18780      +12     
- Partials       3763     3771       +8     
Files with missing lines Coverage Δ Complexity Δ
.../org/hiero/base/crypto/BytesSignatureVerifier.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...us/event/intake/impl/DefaultEventIntakeModule.java 64.58% <100.00%> (+0.37%) 6.00 <0.00> (ø)
...impl/validation/DefaultInternalEventValidator.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...event/intake/utils/DefaultEventFieldValidator.java 98.97% <ø> (ø) 28.00 <0.00> (?)
...impl/signature/DefaultEventSignatureValidator.java 93.54% <88.88%> (+6.51%) 7.00 <1.00> (-3.00) ⬆️
...ava/org/hiero/consensus/crypto/SigningFactory.java 66.66% <0.00%> (-5.34%) 0.00 <0.00> (ø)
...iero/consensus/crypto/internal/SodiumVerifier.java 77.77% <0.00%> (-22.23%) 0.00 <0.00> (ø)
...g/hiero/consensus/crypto/internal/JcaVerifier.java 46.66% <0.00%> (-16.97%) 0.00 <0.00> (ø)
...nsus/event/intake/utils/EventSignatureChecker.java 77.14% <77.14%> (ø) 11.00 <11.00> (?)

... and 13 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce Allocation rate on signature validation

2 participants