feat(24786): Reduce allocation rate sig validation#24828
feat(24786): Reduce allocation rate sig validation#24828mxtartaglia-sl wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 4 medium 8 minor |
| CodeStyle | 10 minor |
| Performance | 3 medium |
🟢 Metrics 47 complexity
Metric Results Complexity 47
🟢 Coverage 79.12% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 79.12% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (defefdc) 96878 78157 80.68% Head commit (68fc534) 96936 (+58) 78204 (+47) 80.68% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24828) 91 72 79.12% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #24828 +/- ##
============================================
- Coverage 76.76% 76.75% -0.01%
- Complexity 11700 11737 +37
============================================
Files 2502 2504 +2
Lines 96975 97033 +58
Branches 10744 10748 +4
============================================
+ Hits 74444 74482 +38
- Misses 18768 18780 +12
- Partials 3763 3771 +8
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description:
Related issue(s):
Fixes #24786
Notes for reviewer:
Checklist